fix(@ngtools/webpack): remove app decorators on AOT - #8506
Merged
Conversation
Based on @clydin's great work in angular#8456. I had to adapt it to use the StandardTransform model we use currently but the logic is his. Should addressed the bigger AOT non-prod builds and memory consumptions in prod build. Fix angular#8457 Partially adresses angular#5618 Supersedes angular#8456
filipesilva
force-pushed
the
remove-app-decorators
branch
from
November 16, 2017 17:43
8150dfe to
066e50c
Compare
filipesilva
force-pushed
the
remove-app-decorators
branch
from
November 16, 2017 18:11
066e50c to
89b76d7
Compare
hansl
approved these changes
Nov 16, 2017
|
It looks like is broken because of this merge at #8525 |
|
This should be removed in like 1.9.4, in 1.8.0 there was no remove decorators and all works, now is not working. Sorry, but it looks like I tried everything, but it is not up to me anymore. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on @clydin's great work in #8456. I had to adapt it to use the StandardTransform model we use currently but the logic is his.
Should addressed the bigger AOT non-prod builds and memory consumptions in prod build.
Fix #8457
Partially adresses #5618
Supersedes #8456